Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging/Rotating the map does not work when mouse is near viewcube #353

Closed
mrpatpat opened this issue Feb 15, 2019 · 2 comments · Fixed by #1827, #2028 or #2063
Closed

Dragging/Rotating the map does not work when mouse is near viewcube #353

mrpatpat opened this issue Feb 15, 2019 · 2 comments · Fixed by #1827, #2028 or #2063
Assignees
@Shivan-997
Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Milestone
bug-hunt

Comments

@mrpatpat
Copy link
Contributor

Bug

Dragging/Rotating the map does not work when mouse is near viewcube. The right events need to be propagated to the codemap and/or the three orbit controls

Expected Behavior

Dragging the map near the viewcube rotates the map.

Actual Behavior

Dragging the map near the viewcube does nothing.
@Richargh Richargh added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. labels Feb 18, 2019
@BridgeAR BridgeAR added the priority:low Set by PO label May 8, 2020
@NearW
Copy link
Contributor

NearW commented Jun 26, 2020

https://stackoverflow.com/questions/46667197/three-js-orbitcontrols-not-working-when-dom-element-is-positioned-over-the-scene

@BridgeAR BridgeAR added priority:high Set by PO and removed priority:low Set by PO labels Dec 23, 2020
@BridgeAR BridgeAR added this to the bug-hunt milestone Jan 1, 2021
@Dmttr Dmttr self-assigned this Feb 17, 2021
@Med-H Med-H mentioned this issue Feb 24, 2021
Merged
@ce-bo ce-bo linked a pull request Feb 26, 2021 that will close this issue
Fix/353/map rotation not working near cube #1827
Merged
Dmttr added a commit that referenced this issue Mar 4, 2021
@Dmttr
Update tests (#353)
1dbaa1f
@Dmttr Dmttr removed a link to a pull request Mar 4, 2021
Fix/353/map rotation not working near cube #1827
Merged
@Dmttr Dmttr linked a pull request Mar 4, 2021 that will close this issue
Fix/353/map rotation not working near cube #1827
Merged
Dmttr added a commit that referenced this issue Mar 17, 2021
@Dmttr
Increase test coverage (#353)
2e19609
RomanenkoVladimir pushed a commit that referenced this issue Mar 17, 2021
@Med-H @Dmttr
Fix/353/map rotation not working near cube (#1827)
e2d1277 
* enable cube rotation

* fixed movement near cube canvas

* Update tests (#353)

* Update CHANGELOG.md

* gradle

* Increase test coverage (#353)

Co-authored-by: Dmytro Hutkin <dmytro.hutkin@gmail.com>
Co-authored-by: DmytroHutkin <41293938+DmytroHutkin@users.noreply.github.com>
@RomanenkoVladimir
Copy link
Member

@DmytroHutkin this currently breaks any user interactions PTAL

@Shivan-997 Shivan-997 assigned Shivan-997 and unassigned Dmttr May 7, 2021
@Shivan-997 Shivan-997 mentioned this issue May 31, 2021
Merged
RomanenkoVladimir added a commit that referenced this issue Jun 3, 2021
@Shivan-997 @Med-H
@Dmttr @RomanenkoVladimir
Fix/353/map rotation not working near cube (#2028)
e923b11 
* enable cube rotation

* fixed movement near cube canvas

* Update tests (#353)

* Update CHANGELOG.md

* gradle

* Increase test coverage (#353)

Co-authored-by: Med-H <mehdihambli@hotmail.com>
Co-authored-by: Dmytro Hutkin <dmytro.hutkin@gmail.com>
Co-authored-by: DmytroHutkin <41293938+DmytroHutkin@users.noreply.github.com>
Co-authored-by: Shivan Oskan <shivan.oskan@maibornwolff.de>
Co-authored-by: RomanenkoVladimir <volodymyr.romanenko@icloud.com>
@Shivan-997 Shivan-997 mentioned this issue Jun 22, 2021
Merged
RomanenkoVladimir added a commit that referenced this issue Jun 25, 2021
@Shivan-997 @Med-H
@Dmttr @RomanenkoVladimir
Fix/353/map rotation not working near cube (#2063)
95e18e2 
* enable cube rotation

* fixed movement near cube canvas

* Update tests (#353)

* Update CHANGELOG.md

* gradle

* Increase test coverage (#353)

* fix test

* run prettier

* add nginject to viewCube.mouseEvents constructor

* fix prettier error

Co-authored-by: Med-H <mehdihambli@hotmail.com>
Co-authored-by: Dmytro Hutkin <dmytro.hutkin@gmail.com>
Co-authored-by: DmytroHutkin <41293938+DmytroHutkin@users.noreply.github.com>
Co-authored-by: Shivan Oskan <shivan.oskan@maibornwolff.de>
Co-authored-by: RomanenkoVladimir <volodymyr.romanenko@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shivan-997 Shivan-997

Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Projects
None yet
Milestone
bug-hunt
7 participants
@mrpatpat @BridgeAR @NearW @RomanenkoVladimir @Richargh @Dmttr @Shivan-997