Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delta values not summed up on folders #781

Closed
NearW opened this issue Nov 13, 2019 · 1 comment · Fixed by #805
Closed

Delta values not summed up on folders #781

NearW opened this issue Nov 13, 2019 · 1 comment · Fixed by #805
Assignees
@alschmut
Labels
pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features.
Milestone
1.41.0

Comments

@NearW
Copy link
Contributor

NearW commented Nov 13, 2019 •
edited

Feature request

Description

Currently we just display the delta-icon without a number when hovering over a folder.
Let's display the sum of all the deltas in that folder when hovering over it.

currently:
Screen Shot 2019-11-13 at 11 29 57
@NearW NearW added the pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. label Nov 13, 2019
alschmut added a commit that referenced this issue Nov 19, 2019
@alschmut
Sum delta values #781
2078eb3
alschmut added a commit that referenced this issue Nov 19, 2019
@alschmut
Refactor and split function #781
5f9094d
alschmut added a commit that referenced this issue Nov 19, 2019
@alschmut
Update CHANGELOG.md #781
9c9b577
@alschmut
Copy link
Contributor

I implemented summing up the delta values, but am not sure, what to do with the sum-icon. I find following options:

  1. Show the sum-icon twice for both values, although this actually takes too much space.
  2. Show the icon once before or after the values (not inside the rounded box). Should it be in a separate rounded box? But which background-color has that box?

image

@alschmut alschmut mentioned this issue Nov 24, 2019
Merged
11 tasks
@Richargh Richargh added this to the 1.41.0 milestone Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alschmut alschmut

Labels
pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features.
Projects
None yet
Milestone
1.41.0
Development

Successfully merging a pull request may close this issue.

Feature/781/sum delta metrics MaibornWolff/codecharta
3 participants
@NearW @alschmut @Richargh