Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing buildings due to margin #821

Open
alexhunziker opened this issue Jan 5, 2020 · 5 comments
Open

Missing buildings due to margin #821

alexhunziker opened this issue Jan 5, 2020 · 5 comments
Labels
bug Only issues that describe bugs. javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Milestone

Comments

@alexhunziker
Copy link
Contributor

alexhunziker commented Jan 5, 2020

Bug

Expected Behavior

Buildings should not disappear based on the margin chosen

Actual Behavior

The margin may cause buildings, which have a non-zero area metric to disappear (i.e. not be displayed).

In the screenshot below, the camera package contains a file with rloc=33 and thus should be displayed. However the folder is shown as if it was empty.

Screenshots

missing_building_cc2

missing_building_cc

Steps to Reproduce the Problem

  1. Select an AreaMetric in which small buildings exist
  2. Increase the Margin
  3. The buildings may disappear due to the margin
@alexhunziker alexhunziker added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. labels Jan 5, 2020
@alschmut
Copy link
Contributor

alschmut commented Jan 5, 2020

Thanks @alexhunziker for adding this bug! This is actually one of the main issues using our treeMap algorithm, because it reduces all building areas in order to increase the margin around.

@BridgeAR BridgeAR added javascript Pull requests that update Javascript code. Usually created by Dependabot. priority:high Set by PO labels Oct 4, 2020
@ce-bo
Copy link
Collaborator

ce-bo commented Dec 16, 2020

In the firefox.cc.json map there are a lot of missing buildings (e.g. the extension folder includes 90 files which are not drawn):
image

@BridgeAR BridgeAR added this to the bug-hunt milestone Jan 1, 2021
@RomanenkoVladimir
Copy link
Member

part of #1609, closing the issue should also close this one

@BridgeAR
Copy link
Member

@RomanenkoVladimir let's keep it open for now. AFAIK it would mostly be fixed but not completely.

@RomanenkoVladimir RomanenkoVladimir added the blocked The issue or feature is blocked on another issue or PR that has to be resolved first label Mar 16, 2021
@BridgeAR
Copy link
Member

This should be fixed by #3077. @RomanenkoVladimir or anyone else, please check if that's the case and close it accordingly.

@BridgeAR BridgeAR removed the blocked The issue or feature is blocked on another issue or PR that has to be resolved first label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Only issues that describe bugs. javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Projects
None yet
Development

No branches or pull requests

5 participants