feature/1255/show-file-count-in-side-bar #1516
Conversation
Testing the actual html content as described in https://docs.angularjs.org/guide/unit-testing would be a nice further test setup for the future
CHANGELOG.md
Outdated
| @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/) | |||
|
|
|||
| ### Added 🚀 | |||
|
|
|||
| - Show file count of folders in Attribute-Side-Bar | |||
There was a problem hiding this comment.
Please include the issue number next to the change, also for added features we decided to try for a bit more elaborate texts to help users catch up.
There was a problem hiding this comment.
What do you think about adding the quick screenshot from PR description?
There was a problem hiding this comment.
And it is added :)
There was a problem hiding this comment.
Good idea, we might use that from now on
| @@ -119,6 +120,13 @@ describe("AttributeSideBarController", () => { | |||
|
|
|||
| expect(attributeSideBarController["_viewModel"].fileName).toEqual("my_fileName") | |||
| }) | |||
|
|
|||
| it("should has fileCount in it's _viewModel", () => { | |||
| } = { | ||
| node: null, | ||
| fileName: null, | ||
| primaryMetricKeys: { node: {}, edge: {} } as PrimaryMetrics, | ||
| secondaryMetricKeys: null, | ||
| isSideBarVisible: null | ||
| isSideBarVisible: null, | ||
| fileCount: 0 |
There was a problem hiding this comment.
We could improve the name a little bit. Suggestion: packageFileCount. Feel free to update the name.
Would love to use something like this html testing. But for now out of scope. I will definitely play around with it sometime :) - If you can show me a quick way with current setup to test it, it would be very appreciated. |
shaman-apprentice
changed the title
|
Two more nits:
|
shaman-apprentice
changed the title
RomanenkoVladimir
deleted the
feature/1255/show-file-count-in-side-bar
branch
Show file count of folders in Attribute-Side-Bar
Please read the CONTRIBUTING.md before opening a PR.
Closes: #1255
Description
s. #1255 and screenshot below
Screenshots or gifs