Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: remove unnecessary break line for secondary metrics #1093 #1672

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Fix: remove unnecessary break line for secondary metrics #1093 #1672

merged 3 commits into from
Jan 15, 2021

Conversation

Shivan-997
Copy link
Contributor

@Shivan-997 Shivan-997 commented Jan 15, 2021 •
edited by ce-bo

Don't break line for secondary metrics span

Please read the CONTRIBUTING.md before opening a PR.

Closes: #1093

Description

The words are forced into one line.

Screenshots or gifs

Screenshot 2021-01-15 at 12 55 48

@RomanenkoVladimir
Copy link
Member

LGTM, need to quickly fix the merge conflict tho
Small nit, could you change Issue: to closes: # number of your PR so it will automatically close on Zenhub (in the PR request)

BridgeAR
BridgeAR requested changes Jan 15, 2021
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for the line break is that the table uses a single column. Instead, we could just combine the column over the whole table width. That way there's no extra line break either and the left column would keep the current size.

@ce-bo ce-bo linked an issue Jan 15, 2021 that may be closed by this pull request
Don't break line for secondary metrics span #1093
Closed
@BridgeAR BridgeAR merged commit 15bebe3 into main Jan 15, 2021
@BridgeAR BridgeAR deleted the fix/1093/fix-unnecessary-break-line-for-secondary-metrics branch January 15, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@RomanenkoVladimir RomanenkoVladimir RomanenkoVladimir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't break line for secondary metrics span
3 participants
@Shivan-997 @RomanenkoVladimir @BridgeAR