Fix: Label over hovered building not shown for height Metric value of… #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanenkoVladimir
added a commit
that referenced
this pull request
Jan 22, 2021
… due to translated component #1690
BridgeAR
approved these changes
Feb 5, 2021
| @@ -16,6 +16,7 @@ export class ThreeCameraService implements CameraChangeSubscriber, CameraSubscri | |||
| private readonly throttledCameraChange: () => void | |||
|
|
|||
| camera: PerspectiveCamera | |||
| threeCameraService: jest.Mock | |||
There was a problem hiding this comment.
A mock in a regular service? Is that intentional?
| @@ -136,6 +136,7 @@ | |||
| "angularjs-color-picker": "^3.4.8", | |||
| "babel-loader": "^8.1.0", | |||
| "bestzip": "^2.1.5", | |||
| "canvas": "^2.6.1", | |||
There was a problem hiding this comment.
Is it intentional that this is added? I can't find any usage in this code?
| } | ||
| labelText += `${node.attributes[state.dynamicSettings.heightMetric]} ${state.dynamicSettings.heightMetric}` |
There was a problem hiding this comment.
Are we safe that node.attributes is indeed an object? We originally had a safeguard at the top (node.attributes?.).
Comment on lines
+85
to
+87
| // !remark : algorithm scaling is not same as the squarified layout, | ||
| // !layout offset needs to be scaled down,the divided by value is just empirical, | ||
| // TODO !needs further investigation |
There was a problem hiding this comment.
We might find a nicer description here but I can't think of anything right now :)
| sprite.scale.set((distance / this.LABEL_WIDTH_DIVISOR) * labelWidth, distance / 25, 1) | ||
| } else { | ||
| sprite.scale.set((distance / this.LABEL_WIDTH_DIVISOR) * labelWidth, distance / this.LABEL_HEIGHT_DIVISOR, 1) | ||
| if (this.threeCameraService.camera) { |
There was a problem hiding this comment.
Was this check not necessary before?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… zero #1623
Hovering some leaves does not show a temporary label
Please read the CONTRIBUTING.md before opening a PR.
Closes: #1623
Description
codeMapLabelService should add label even if node has a height attribute value of 0.
Notes: There is no Bug in Multiple Mode because we have found that in multiple mode there must be common metrics in order to be visualize the multiple "maps".
Screenshots or gifs