Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/1606/switching maps in delta shows no change #1705

Merged
merged 4 commits into from
Feb 5, 2021
Merged

Fix/1606/switching maps in delta shows no change #1705

merged 4 commits into from
Feb 5, 2021

Conversation

JaiJoPa
Copy link
Contributor

@JaiJoPa JaiJoPa commented Jan 29, 2021

Switching maps in Delta Mode

Please read the CONTRIBUTING.md before opening a PR.

fixes: #1606

Description

  • This PR fixes the bug, that the differences between two maps were not shown when switching maps.
  • Switching the maps did not show any differences because the reference map remained the same while the comparison map became the reference map. So we compared the same maps in delta.
  • This happened because there was a wrong allocation of the reference map when changing the origin reference map.

Screenshots or gifs

switchMaps

BridgeAR
BridgeAR approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@RomanenkoVladimir RomanenkoVladimir merged commit 7b3486d into main Feb 5, 2021
@RomanenkoVladimir RomanenkoVladimir deleted the fix/1606/switching-maps-in-delta-shows-no-change branch February 5, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@RomanenkoVladimir RomanenkoVladimir RomanenkoVladimir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delta mode showing no changes
3 participants
@JaiJoPa @BridgeAR @RomanenkoVladimir