Fix/1592/slider not initialized correctly #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christian-Eberhard
added
bug
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
|
RomanenkoVladimir
requested changes
Mar 26, 2021
There was a problem hiding this comment.
LGTM in general, I have a few small nits:
- The tests seems to be incorrect, you should take another look at the mocking library.
- It seems you forgot to run prettier :)
- Please update the CHANGELOG.md file with your changes/bug fixes
- And for the PR text please change Issue: yourIssueNumber to closes: yourIssueNumber so it will automatically close the PR on merging the branch :)
…correctly' into fix/1592/Slider-not-initialized-correctly
…er-not-initialized-correctly
…correctly' into fix/1592/Slider-not-initialized-correctly # Conflicts: # CHANGELOG.md
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
|
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
RomanenkoVladimir
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{Adding forced rerender to properly set slider}
closes: #1592
Description