Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/901/same size after reincluding buildings #2297

Merged
merged 11 commits into from
Jul 16, 2021
Merged

Fix/901/same size after reincluding buildings #2297

merged 11 commits into from
Jul 16, 2021

Conversation

ngormsen
Copy link
Contributor

Prohibits user from excluding every building on the map

Closes: #901

Description

  • It is no longer possible to exclude every building on the map
  • Displays an error message when the user tries to exclude every building
  • This also applies when the user excludes every building on the map with a search query like "*"

Screenshots or gifs

@ngormsen ngormsen added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO labels Jul 14, 2021
@ngormsen ngormsen self-assigned this Jul 14, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2021

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2021

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

98.2% 98.2% Coverage
0.0% 0.0% Duplication

@RomanenkoVladimir RomanenkoVladimir merged commit e3e44ef into main Jul 16, 2021
@RomanenkoVladimir RomanenkoVladimir deleted the fix/901/same-size-after-reincluding-buildings branch July 16, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanenkoVladimir RomanenkoVladimir RomanenkoVladimir approved these changes

Assignees

@ngormsen ngormsen

Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Projects
None yet
Milestone
No milestone
2 participants
@ngormsen @RomanenkoVladimir