Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Changelog Guidelines #2352 #2358

Merged
merged 5 commits into from Sep 13, 2021
Merged

Conversation

IhsenBouallegue
Copy link
Collaborator

Add Changelog Guidelines

Issue: #2352

Description

  • The changelog entries do not follow any pattern and are sometimes confusing.
  • Add changelog guidelines for the developers to help further clarify how and when to add to the changelog file

CONTRIBUTING.md Outdated

###How to write a good description?

- The description should be precise and short. Please keep it in one sentence (Max. 2).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruben suggested a while ago to describe the behavior of (for example) a new feature in detail. I like this idea and personally would keep it instead of writing just one sentence :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense from a developer point of view. But as a user, I want a straight to the point description. What I mean is the changelog can give you a quick glance on something. If one wants to understand the details, they can click on the link for the Pull Request/Issue/documentation. That's what I noticed at least from researching changelogs of other projects.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, as a User I would be happy about tipps regarding the usage of the new feature. Therefore I wouldn't restrict the changelog description to be as short as possible. What do you think about something like this: "The description should be precise and short to provide the user with all neccessary information. If it makes sense, add some precise notes about the usage of the new feature."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good! Okay I will change it to that

CONTRIBUTING.md Outdated Show resolved Hide resolved
@ce-bo ce-bo linked an issue Sep 6, 2021 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2021

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2021

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ce-bo ce-bo merged commit e02a6b4 into main Sep 13, 2021
@ce-bo ce-bo deleted the docs/2352/create-changelog-guidelines branch September 13, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create guideline "how-to-changelog"
2 participants