Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/2330/legend improvements #2367

Merged
merged 14 commits into from
Sep 17, 2021
Merged

Feature/2330/legend improvements #2367

merged 14 commits into from
Sep 17, 2021

Conversation

jannikr
Copy link
Contributor

@jannikr jannikr commented Sep 13, 2021

Legend improvements

closes: #2330

Description

Descriptive pull request text, answering:

  • Changing the background color
  • Remove "outgoing" and "incoming" edges from the legend, if not applicable
  • Add all used metrics to the legend
  • Add a list of known metric descriptions to the frontend and show a translation next to the entry

Screenshots or gifs

Bildschirmfoto 2021-09-13 um 15 34 31

@jannikr jannikr marked this pull request as draft September 13, 2021 14:29
ce-bo
ce-bo reviewed Sep 14, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
ce-bo
ce-bo reviewed Sep 14, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@jannikr jannikr marked this pull request as ready for review September 16, 2021 12:42
ce-bo
ce-bo reviewed Sep 17, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
ce-bo
ce-bo approved these changes Sep 17, 2021
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Looking Good To Me)!
Please check one last suggestion and feel free to merge 🚀

jannikr and others added 2 commits September 17, 2021 09:17
@jannikr @ce-bo
Update CHANGELOG.md
d3edc8a 
Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
@ce-bo
Merge branch 'main' into feature/2330/legend-improvements
5e9eeb9
@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2021

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2021

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jannikr jannikr merged commit 953c05e into main Sep 17, 2021
@jannikr jannikr deleted the feature/2330/legend-improvements branch September 17, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ce-bo ce-bo ce-bo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Legend improvements
2 participants
@jannikr @ce-bo