Fix/2377/improve metric descriptions in legend

[jannikr]

Improve metric descriptions in legend

closes #2377

Description

-The metric label is not shown, if no description is available.
-More basic metric descriptions are provided. Especially for loc and comment_lines

[ce-bo]

Thanks for the PR and the fix.
Since I see the solution now, I would rather hide the following part : <empty description>. The label should be still visible, even if no description is available. Thus, the legend would provide information of the choosen metrics all the time.

Would you please so kind and change this?

[jannikr]

@ce-bo I've been thinking about that, too. I just wonder then what added value the legend brings. The selected metric can also be seen in the bar at the top of the screen.

[ce-bo]

@jannikr That's true. For the case, that we take a screenshot, we need the metric information to be included in the legend.

[Shivan-997]

Notice: do not Squash and merge. there is some changes coming.

[jannikr]

@ce-bo Please note my new commit.

The screenshot shows the behavior when descriptions are missing.

[ce-bo]

Thank you @jannikr 👍
I think you could have done it by applying the ng-if to the span. This would be less "html-verbose".

[sonarcloud]

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[sonarcloud]

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication