Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2393/risk-profile-total-sum-of-percentages #2516

Merged
merged 4 commits into from Nov 19, 2021

Conversation

Hall-Ma
Copy link
Contributor

@Hall-Ma Hall-Ma commented Nov 18, 2021

Sum of all percentages of the risk profile exceeds 100

Close: #2393

Description

  • The sum of all percentages of the risk profile can exceed 100 percent under certain circumstances
  • Now package https://www.npmjs.com/package/percent-round is used and the sum of all percentages are always 100 (rounding is based on largest remainder method)

Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests. Please use a largest remainder method to always achieve 100%. Percent round should work fine.

@sonarcloud
Copy link

sonarcloud bot commented Nov 19, 2021

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Nov 19, 2021

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ce-bo ce-bo merged commit b656e7c into main Nov 19, 2021
@ce-bo ce-bo deleted the fix/2393/risk-profile-total-sum-of-percentages branch November 19, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Risk Profiles: Total Sum of percentages exceeds 100%
3 participants