Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/2524/solve-map-loading-of-compressed-files #2525

Merged
merged 7 commits into from Nov 29, 2021
Merged

Fix/2524/solve-map-loading-of-compressed-files #2525

merged 7 commits into from Nov 29, 2021

Conversation

Hall-Ma
Copy link
Contributor

@Hall-Ma Hall-Ma commented Nov 26, 2021 •
edited by ce-bo

Compressed files not being loaded

Issue: #2524

Description

Compressed files are not accepted after the 1.83.1 patch because of a missing string cast.

@IhsenBouallegue IhsenBouallegue marked this pull request as ready for review November 26, 2021 13:53
BridgeAR
BridgeAR reviewed Nov 27, 2021
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have a test to guard against similar issues in the future. :-)

@ce-bo
Copy link
Collaborator

ce-bo commented Nov 29, 2021

Please adjust CHANGELOG.md

ce-bo
ce-bo reviewed Nov 29, 2021
View reviewed changes
visualization/package.json Outdated Show resolved Hide resolved
ce-bo
ce-bo approved these changes Nov 29, 2021
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please remove the change in package.json first.
In the next step, after hotfix release, we should manage to generate an up-to-date .gz file during our build pipeline. This file can then be used in an e2e test for testing the upload of zipped files.

@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2021

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2021

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@IhsenBouallegue IhsenBouallegue merged commit f4fe2c0 into main Nov 29, 2021
@IhsenBouallegue IhsenBouallegue deleted the fix/2524/solve-map-loading-of-compressed-files branch November 29, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@ce-bo ce-bo ce-bo approved these changes

Assignees

@IhsenBouallegue IhsenBouallegue

@Hall-Ma Hall-Ma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Hall-Ma @ce-bo @BridgeAR @IhsenBouallegue