New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/2480/loading formerly loaded files #2548
Conversation
… possible Refactor some variables #2480
@@ -1,7 +1,7 @@ | |||
{ | |||
"projectName": "Sample Project with Edges", | |||
"apiVersion": "1.2", | |||
"fileChecksum": "invalid-md5-sample", | |||
"fileChecksum": "valid-md5-sample1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit picking: Intentionally, "invalid-md5-sample" should express that the sample value is not a valid md5. So, "valid-md5-sample" is a bit confusing here. I agree that the former is not that obvious. Therefore, we could just omit the prefix "valid".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! However, we could remove the recentFiles handling from the store because it is nowhere else needed and it just makes no sense to dispatch this. The recentFiles array is used to get access to the first uploaded file, so that it can be marked as selected. This can be done locally in codeCharta.service.ts.
Loading formerly loaded files
Close: #2480
Description
Problem:
Solution: