Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2489/Remove-suspicious-metrics-from-custom-config #2564

Merged

Conversation

Hall-Ma
Copy link
Contributor

@Hall-Ma Hall-Ma commented Dec 17, 2021

Removing suspicious metrics from custom config

ref: #2489

Description

  • To reduce the load on the user's local storage, the suspicious metrics are no longer stored in the custom configs.
  • Overall, this leads to better performance.

Copy link
Collaborator

@IhsenBouallegue IhsenBouallegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Hall-Ma Hall-Ma requested a review from ce-bo December 29, 2021 15:57
@Hall-Ma Hall-Ma requested a review from ce-bo December 30, 2021 17:28
@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2021

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2021

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.3% 94.3% Coverage
0.0% 0.0% Duplication

@Hall-Ma Hall-Ma merged commit bfde98b into main Dec 31, 2021
@Hall-Ma Hall-Ma deleted the feature/2489/remove-suspicious-metrics-from-custom-config branch December 31, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants