Feature/2489/Do-not-show-non-matching-entries-by-default #2591
Conversation
|
I like your implementation suggestion 👍 |
|
@BridgeAR What do you think about it? |
Hall-Ma
changed the title
…nd expanding entries of all found configs if wanted #2489
|
I'm not satisfied with my implementation when 'show more' or 'show less' button is activated/deactivated. The change is unfortunately very lazy at the moment. Is there any suggestion for a better implementation? |
| if (dropDownCustomConfigItemGroups[dropDownCustomConfigItemGroupIndex].customConfigItems.length === 0) { | ||
| dropDownCustomConfigItemGroups.splice(dropDownCustomConfigItemGroupIndex, 1) | ||
| this._viewModel.visibleEntries-- | ||
| this.previousEntries-- |
There was a problem hiding this comment.
Please check this condition closely. It might contain a subtle bug. I would expect to only count previousEntries down in case the current removed item (index) is below or equal to previousEntries.
There was a problem hiding this comment.
I get your point. Now I wrote the logic a bit different and hope I catch every edge case.
visualization/app/codeCharta/ui/customConfigs/customConfigs.component.ts
Outdated
Show resolved
Hide resolved
…and removing custom configs from the list correctly #2489
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
|
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
Hall-Ma
deleted the
feature/2489/do-not-show-non-matching-entries-by-default
branch
Show or hide non-applicable custom configs in custom config drop down menu
ref: #2489
Description
Gif