Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/2562/Selected-color-building-in-delta-mode #2603

Merged
merged 5 commits into from Jan 14, 2022
Merged

Fix/2562/Selected-color-building-in-delta-mode #2603

merged 5 commits into from Jan 14, 2022

Conversation

Hall-Ma
Copy link
Contributor

@Hall-Ma Hall-Ma commented Jan 12, 2022 •
edited by ce-bo

Color change of the selected building in delta mode

Closes: #2562

Description

  • When a building is selected (left mouse click) in delta mode, the whole building is now colored (with selected color)

@Hall-Ma Hall-Ma added this to the Good first issues milestone Jan 12, 2022
ce-bo
ce-bo approved these changes Jan 12, 2022
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM (but not tested locally on my machine) :-)

@sonarcloud
Copy link

sonarcloud bot commented Jan 14, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@IhsenBouallegue
Copy link
Collaborator

Tested locally, works. But there seems to be a weird problem with gradle. I relaunched the GitHub actions. Hopefully that does the trick

@sonarcloud
Copy link

sonarcloud bot commented Jan 14, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@IhsenBouallegue
Copy link
Collaborator

Looks good 👍

@ce-bo ce-bo merged commit 72a227b into main Jan 14, 2022
@ce-bo ce-bo deleted the fix/2562/selected-color-building-in-delta-mode branch January 14, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ce-bo ce-bo ce-bo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Good first issues
Development

Successfully merging this pull request may close these issues.

Selected building in delta mode has not selected color
3 participants
@Hall-Ma @IhsenBouallegue @ce-bo