Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add invert area #697 #2626

Merged
merged 4 commits into from Jan 31, 2022
Merged

add invert area #697 #2626

merged 4 commits into from Jan 31, 2022

Conversation

Shivan-997
Copy link
Contributor

@Shivan-997 Shivan-997 commented Jan 24, 2022

add invert the amount of area, which is used for the nodes

issue: #697

Screenshots or gifs

image

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a new component. So, we should migrate this to Angular.
I would be fine to merge this PR (but do not close the issue) and to create another follow up PR for the migration.

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

96.2% 96.2% Coverage
0.0% 0.0% Duplication

@Shivan-997 Shivan-997 merged commit c05572d into main Jan 31, 2022
@Shivan-997 Shivan-997 deleted the feature/697/invert-area branch January 31, 2022 09:45
@Hall-Ma Hall-Ma linked an issue Feb 3, 2022 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invert AreaMetric
3 participants