New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2499/show garbage bin next to the loaded maps #2647
Merged
ce-bo
merged 14 commits into
main
from
feature/2499/show-garbage-bin-next-to-the-loaded-maps
Feb 14, 2022
Merged
Feature/2499/show garbage bin next to the loaded maps #2647
ce-bo
merged 14 commits into
main
from
feature/2499/show-garbage-bin-next-to-the-loaded-maps
Feb 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i am not sure if it is the best solution to just disable button when only one map left. |
https://github.com/MaibornWolff/codecharta into feature/2499/show-garbage-bin-next-to-the-loaded-maps
Christian-Eberhard
suggested changes
Feb 14, 2022
...ation/app/codeCharta/ui/filePanel/filePanelFileSelector/filePanelFileSelector.component.scss
Outdated
Show resolved
Hide resolved
...deCharta/ui/filePanel/filePanelFileSelector/removeFileButton/removeFileButton.component.html
Outdated
Show resolved
Hide resolved
Christian-Eberhard
approved these changes
Feb 14, 2022
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! |
[CodeCharta Visualization] SonarCloud Quality Gate failed. |
ce-bo
deleted the
feature/2499/show-garbage-bin-next-to-the-loaded-maps
branch
February 14, 2022 12:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show garbage bin next to the loaded maps
closes: #2499
Screenshots or gifs