Fixes floor labels being drawn next to map #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce-bo
reviewed
Mar 30, 2022
visualization/app/codeCharta/ui/codeMap/threeViewer/floorLabels/floorLabelDrawer.ts
Outdated
Show resolved
Hide resolved
ce-bo
reviewed
Mar 30, 2022
ce-bo
approved these changes
Mar 30, 2022
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
|
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
Christian-Eberhard
deleted the
fix/2611/floor-labels-drawn-next-to-the-map
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes floor labels being drawn next to map
Closes: #2611
Description
Fixes the issue of the floor labels being drawn next to map, after changing the margin when the height was not equal to 1.