Fixes floor labels being stuck inside folder geometry when scaling #2766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 30, 2022 17:01
…-inside-of-folder-geometry-when-changing-height-scaling # Conflicts: # visualization/app/codeCharta/ui/codeMap/threeViewer/floorLabels/floorLabelDrawer.ts
ce-bo
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
LGTM. I tested it on my machine. Would you please fix the tests?
I found another edge case: Set Height Scaling to minimum and Margins to Maximum.
Then, some floor labels were lost. Would you have a quick look on that, please? Maybe we should fix that in a follow up issue.
…try-when-changing-height-scaling
…try-when-changing-height-scaling
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
|
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
ce-bo
deleted the
fix/2764/floor-labels-inside-of-folder-geometry-when-changing-height-scaling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes floor labels being stuck inside folder geometry when scaling
Closes: #2764
Description
Moves the canvases according to the folder level and changed scale