use interface for interactive parsers + implement in ValidatorTool #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows us to automatically detect them from the subcommands, and makes a separate map unnecessary
IhsenBouallegue
approved these changes
May 25, 2022
| package de.maibornwolff.codecharta.tools.interactiveparser | ||
|
|
||
| interface InteractiveParser { | ||
| fun callInteractive() |
There was a problem hiding this comment.
The name callInteractive can create a bit of confusion. It can seem as if it's an alternative to the method call that's needed for the CLI which includes the logic of the parsers. This method however has nothing to do with the logic. I suggest mainWithInteractiveDialog or executeWithInteractiveDialog
|
Can't merge because test coverage is under 80% |
|
Please add a changelog entry |
IhsenBouallegue
approved these changes
May 31, 2022
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! |
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use interface for interactive parsers + implement in ValidatorTool
Issue: #2341
Description
Screenshots or gifs