Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default metrics on file change in case default scenario is not a… #2828

Merged
merged 5 commits into from Jun 1, 2022
Merged

fix: default metrics on file change in case default scenario is not a… #2828

merged 5 commits into from Jun 1, 2022

Conversation

shaman-apprentice
Copy link
Contributor

close #2826

@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

IhsenBouallegue
IhsenBouallegue approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@IhsenBouallegue IhsenBouallegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@IhsenBouallegue IhsenBouallegue merged commit aa0b556 into main Jun 1, 2022
@IhsenBouallegue IhsenBouallegue deleted the fix/2826/default-metrics-on-file-change branch June 1, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IhsenBouallegue IhsenBouallegue IhsenBouallegue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Area, Height and Color Metrics are resetted on file uploads
2 participants
@shaman-apprentice @IhsenBouallegue