Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preselect metrics from metric gardener as defaults #2908

Closed
ce-bo opened this issue Jul 25, 2022 · 1 comment · Fixed by #2910
Closed

Preselect metrics from metric gardener as defaults #2908

ce-bo opened this issue Jul 25, 2022 · 1 comment · Fixed by #2910
Assignees
@jannikr @Hall-Ma @MW-Friedrich
Milestone
automation-basics-2

Comments

@ce-bo
Copy link
Collaborator

ce-bo commented Jul 25, 2022 •
edited

Feature request

Description

As a User of CodeCharta, I want CodeCharta to preselect metrics that have been imported by MetricGardenerImporter, so that I don't have to select them manually.

Acceptance criteria (the following size and complexity metrics should be covered by our preselection logic of #1532 if not already done).

  • classes
  • functions
  • lines_of_code
  • real_lines_of_code
@ce-bo ce-bo added this to the automation-basics-2 milestone Jul 25, 2022
@ce-bo
Copy link
Collaborator Author

ce-bo commented Jul 25, 2022

I think only real_lines_of_code is missing.

jannikr added a commit that referenced this issue Jul 26, 2022
@jannikr
Add real_lines_of_code to sizeMetrics #2908
49c743e
jannikr added a commit that referenced this issue Jul 26, 2022
@jannikr
Change CHANGELOG.md #2908
e1848be
@jannikr jannikr mentioned this issue Jul 26, 2022
Merged
jannikr added a commit that referenced this issue Jul 26, 2022
@jannikr @MW-Friedrich
Feature/2908/preselect metrics from metric gardener (#2910)
038d058 
* Add real_lines_of_code to sizeMetrics #2908

* Change CHANGELOG.md #2908

* Update CHANGELOG.md

* Update CHANGELOG.md

Move the "add more metrics" part up to the "Changed" section

* Update CHANGELOG.md

Co-authored-by: MW-Friedrich <108457762+MW-Friedrich@users.noreply.github.com>
@MW-Friedrich MW-Friedrich linked a pull request Jul 26, 2022 that will close this issue
Feature/2908/preselect metrics from metric gardener #2910
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jannikr jannikr

@Hall-Ma Hall-Ma

@MW-Friedrich MW-Friedrich

Labels
None yet
Projects
None yet
Milestone
automation-basics-2
Development

Successfully merging a pull request may close this issue.

Feature/2908/preselect metrics from metric gardener MaibornWolff/codecharta
4 participants
@ce-bo @jannikr @Hall-Ma @MW-Friedrich