Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/2908/preselect metrics from metric gardener #2910

Merged
merged 6 commits into from
Jul 26, 2022
Merged

Feature/2908/preselect metrics from metric gardener #2910

merged 6 commits into from
Jul 26, 2022

Conversation

jannikr
Copy link
Contributor

@jannikr jannikr commented Jul 26, 2022

Preselect metrics from metric gardener as default

Issue: #2908

ce-bo
ce-bo reviewed Jul 26, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
MW-Friedrich
MW-Friedrich approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@MW-Friedrich MW-Friedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After very careful consideration, I can say this looks good to me! 🚀

@MW-Friedrich
Update CHANGELOG.md
5373850
@MW-Friedrich
Update CHANGELOG.md
51c538a 
Move the "add more metrics" part up to the "Changed" section
@MW-Friedrich
Update CHANGELOG.md
78d31cc
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jannikr jannikr merged commit 038d058 into main Jul 26, 2022
@jannikr jannikr deleted the feature/2908/preselect-metrics-from-metric-gardener branch July 26, 2022 09:38
@MW-Friedrich MW-Friedrich linked an issue Jul 26, 2022 that may be closed by this pull request
Preselect metrics from metric gardener as defaults #2908
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MW-Friedrich MW-Friedrich MW-Friedrich approved these changes

@ce-bo ce-bo ce-bo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preselect metrics from metric gardener as defaults
3 participants
@jannikr @ce-bo @MW-Friedrich