Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccsh merge throws NoSuchMethodException #2930

Merged
merged 6 commits into from Aug 3, 2022
Merged

ccsh merge throws NoSuchMethodException #2930

merged 6 commits into from Aug 3, 2022

Conversation

phanlezz
Copy link
Collaborator

@phanlezz phanlezz commented Aug 2, 2022 •
edited by ce-bo

Change CompressedStreamHandler usage of java11 method to java8 #2923

Close: #2923

Description

Fix for the NoSuchMethodException in CompressedStreamHandler through a switch of the java11 method to the java8 equivalent.

@phanlezz phanlezz self-assigned this Aug 2, 2022
ce-bo
ce-bo reviewed Aug 2, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@phanlezz phanlezz requested a review from ce-bo August 3, 2022 00:57
ce-bo
ce-bo approved these changes Aug 3, 2022
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Regarding the changelog, I would try to express why the fix was necessary. In this case you fixed a NoSuchMethodException due to a call of method readNBytes() that is not available in Java 9 and you replaced it with read()

@ce-bo ce-bo changed the title ccsh merge throws NoSuchMethodError ccsh merge throws NoSuchMethodException Aug 3, 2022
@ce-bo
Copy link
Collaborator

ce-bo commented Aug 3, 2022

I editet the description from Issue #2923 to Close #2923. By this, GitHub will close the referenced issue automatically.

@phanlezz
Copy link
Collaborator Author

phanlezz commented Aug 3, 2022

LGTM, thanks! Regarding the changelog, I would try to express why the fix was necessary. In this case you fixed a NoSuchMethodException due to a call of method readNBytes() that is not available in Java 9 and you replaced it with read()

Ahh, that's better, thanks! I will add that 👍

I editet the description from Issue #2923 to Close #2923. By this, GitHub will close the referenced issue automatically.

Nice, I had a close statement in commit ea8d3fb already, but this will work also 👍

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.8% 93.8% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.1% 95.1% Coverage
0.0% 0.0% Duplication

@phanlezz phanlezz merged commit 4c1ed2f into main Aug 3, 2022
@phanlezz phanlezz deleted the fix/2923/ccsh-merge-throws-nosuchmethoderror branch August 3, 2022 08:45
@phanlezz phanlezz mentioned this pull request Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ce-bo ce-bo ce-bo approved these changes

Assignees

@phanlezz phanlezz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ccsh merge throws NoSuchMethodError
2 participants
@phanlezz @ce-bo