Feature/2744/copy filenames to clipboard #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce-bo
reviewed
Aug 8, 2022
visualization/app/codeCharta/ui/copyToClipboardButton/getFilenamesWithHighestMetrics.ts
Outdated
Show resolved
Hide resolved
ce-bo
reviewed
Aug 8, 2022
visualization/app/codeCharta/ui/copyToClipboardButton/getFilenamesWithHighestMetrics.ts
Outdated
Show resolved
Hide resolved
ce-bo
reviewed
Aug 8, 2022
visualization/app/codeCharta/ui/copyToClipboardButton/getFilenamesWithHighestMetrics.ts
Outdated
Show resolved
Hide resolved
ce-bo
reviewed
Aug 8, 2022
ce-bo
reviewed
Aug 8, 2022
5 tasks
Hall-Ma
reviewed
Aug 9, 2022
visualization/app/codeCharta/ui/copyToClipboardButton/util/getFilenamesWithHighestMetrics.ts
Outdated
Show resolved
Hide resolved
Hall-Ma
reviewed
Aug 9, 2022
visualization/app/codeCharta/ui/copyToClipboardButton/util/getFilenamesWithHighestMetrics.ts
Outdated
Show resolved
Hide resolved
…enames-to-clipboard
[Maintenability was prefered over best perfomance]
visualization/app/codeCharta/ui/copyToClipboardButton/copyToClipboard.service.spec.ts
Show resolved
Hide resolved
visualization/app/codeCharta/ui/copyToClipboardButton/copyToClipboard.service.spec.ts
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/copyToClipboardButton/copyToClipboard.service.spec.ts
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/copyToClipboardButton/copyToClipboardButton.component.scss
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/copyToClipboardButton/copyToClipboardButton.component.spec.ts
Show resolved
Hide resolved
visualization/app/codeCharta/ui/copyToClipboardButton/copyToClipboardButton.component.spec.ts
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/copyToClipboardButton/copyToClipboardButton.component.spec.ts
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/copyToClipboardButton/copyToClipboardButton.component.ts
Show resolved
Hide resolved
Hall-Ma
reviewed
Aug 16, 2022
visualization/app/codeCharta/ui/copyToClipboardButton/util/clipboardString.spec.ts
Show resolved
Hide resolved
Hall-Ma
reviewed
Aug 16, 2022
visualization/app/codeCharta/ui/copyToClipboardButton/util/clipboardString.spec.ts
Outdated
Show resolved
Hide resolved
Hall-Ma
reviewed
Aug 16, 2022
...alization/app/codeCharta/ui/copyToClipboardButton/util/getFilenamesWithHighestMetric.spec.ts
Outdated
Show resolved
Hide resolved
Hall-Ma
reviewed
Aug 16, 2022
...alization/app/codeCharta/ui/copyToClipboardButton/util/getFilenamesWithHighestMetric.spec.ts
Outdated
Show resolved
Hide resolved
Hall-Ma
reviewed
Aug 16, 2022
...alization/app/codeCharta/ui/copyToClipboardButton/util/getFilenamesWithHighestMetric.spec.ts
Outdated
Show resolved
Hide resolved
Hall-Ma
reviewed
Aug 16, 2022
...alization/app/codeCharta/ui/copyToClipboardButton/util/getFilenamesWithHighestMetric.spec.ts
Show resolved
Hide resolved
Hall-Ma
reviewed
Aug 16, 2022
visualization/app/codeCharta/ui/copyToClipboardButton/util/getFilenamesWithHighestMetrics.ts
Show resolved
Hide resolved
Hall-Ma
reviewed
Aug 16, 2022
visualization/app/codeCharta/ui/copyToClipboardButton/util/getFilenamesWithHighestMetrics.ts
Outdated
Show resolved
Hide resolved
Hall-Ma
previously approved these changes
Aug 16, 2022
Hall-Ma
dismissed
their stale review
Please look into my comments before merging. I have misclicked :D
shaman-apprentice
approved these changes
Aug 18, 2022
…enames-to-clipboard
…enames-to-clipboard
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
|
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy worst metric violators directly to your clipboard
Issue: #2744
Description
Users want to quickly share a summary of files with high metric values (violators).
For this, we added a button (copy-to-clipboard) with which you can paste a summary of the worst violators. This summary contains a top10-list for every metric and it lists the names of the files with the highest metric values. We also included the metric value next to every filename.
Screenshots or gifs