Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nw version to be able to run codecharta for mac via npm #2967 #2974

Merged
merged 3 commits into from Aug 10, 2022
Merged

Update nw version to be able to run codecharta for mac via npm #2967 #2974

merged 3 commits into from Aug 10, 2022

Conversation

jannikr
Copy link
Contributor

@jannikr jannikr commented Aug 10, 2022

Run codecharta for mac via npm

Issue: #2967

phanlezz
phanlezz approved these changes Aug 10, 2022
View reviewed changes
Copy link
Collaborator

@phanlezz phanlezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

MW-Friedrich
MW-Friedrich reviewed Aug 10, 2022
View reviewed changes
Copy link
Contributor

@MW-Friedrich MW-Friedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I do not have a mac, the code changes look good to me!

@jannikr jannikr enabled auto-merge (squash) August 10, 2022 12:55
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jannikr jannikr merged commit 91a6ce0 into main Aug 10, 2022
@jannikr jannikr deleted the fix/2967/visualization-does-not-start-under-macos branch August 10, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MW-Friedrich MW-Friedrich MW-Friedrich left review comments

@phanlezz phanlezz phanlezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jannikr @phanlezz @MW-Friedrich