Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permission to upload-assets action #2978 #2979

Merged
merged 3 commits into from Aug 12, 2022
Merged

Add permission to upload-assets action #2978 #2979

merged 3 commits into from Aug 12, 2022

Conversation

jannikr
Copy link
Contributor

@jannikr jannikr commented Aug 11, 2022 •
edited

Add permission to upload-assets action

Issue: #2978

shaman-apprentice
shaman-apprentice previously requested changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@shaman-apprentice shaman-apprentice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need https://github.com/alexellis/upload-assets? I am not too happy about using a lib with only 31 stars. There must be a more standard way to do it. I would be fine with approving for now, when we have a follow up ticket.

ce-bo
ce-bo approved these changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ce-bo
Copy link
Collaborator

ce-bo commented Aug 11, 2022

Do we really need https://github.com/alexellis/upload-assets? I am not too happy about using a lib with only 31 stars. There must be a more standard way to do it. I would be fine with approving for now, when we have a follow up ticket.

@shaman-apprentice We use this action already since a while. But it is not following SemVer. I like your suggestion to check, if we can use a stable library. But for now it is working and I would not invest that much time to change it.

@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phanlezz phanlezz merged commit 27a8bd8 into main Aug 12, 2022
@phanlezz phanlezz deleted the fix/2978/upload-assets-socket-hang-up branch August 12, 2022 09:10
@phanlezz phanlezz linked an issue Aug 12, 2022 that may be closed by this pull request
Upload Release Files #2978
Closed
@phanlezz phanlezz mentioned this pull request Aug 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ce-bo ce-bo ce-bo approved these changes

@shaman-apprentice shaman-apprentice shaman-apprentice left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload Release Files
4 participants
@jannikr @ce-bo @shaman-apprentice @phanlezz