Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix element not explicitly added to DOM #3017 #3042

Merged
merged 4 commits into from Sep 19, 2022
Merged

Fix element not explicitly added to DOM #3017 #3042

merged 4 commits into from Sep 19, 2022

Conversation

RomanenkoVladimir
Copy link
Member

Fix Safari cc-json file loading issue

Please read the CONTRIBUTING.md before opening a PR.

closes: #3017

Description

Safari 15 requires input to be appended to the DOM, modified this to fix the issue.

Screenshots or gifs

@RomanenkoVladimir RomanenkoVladimir self-assigned this Sep 19, 2022
MW-Friedrich
MW-Friedrich approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@MW-Friedrich MW-Friedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RomanenkoVladimir RomanenkoVladimir enabled auto-merge (squash) September 19, 2022 14:19
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@RomanenkoVladimir RomanenkoVladimir merged commit e3e5b45 into main Sep 19, 2022
@RomanenkoVladimir RomanenkoVladimir deleted the fix/3017/cant-load-cc-json-in-safari branch September 19, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MW-Friedrich MW-Friedrich MW-Friedrich approved these changes

Assignees

@RomanenkoVladimir RomanenkoVladimir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't load CC.JSON files on Safari
2 participants
@RomanenkoVladimir @MW-Friedrich