Feature/2584/adjust default number of displayed labels #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
reviewed
Sep 21, 2022
...zation/app/codeCharta/state/store/appSettings/amountOfTopLabels/amountOfTopLabels.actions.ts
Outdated
Show resolved
Hide resolved
… top labels, event handling is still WIP #2584
BridgeAR
reviewed
Sep 21, 2022
...ation/app/codeCharta/state/store/appSettings/amountOfTopLabels/amountOfTopLabels.selector.ts
Outdated
Show resolved
Hide resolved
...ation/app/codeCharta/state/store/appSettings/amountOfTopLabels/amountOfTopLabels.selector.ts
Outdated
Show resolved
Hide resolved
… of github.com:MaibornWolff/codecharta into feature/2584/adjust-default-number-of-displayed-labels
|
@shaman-apprentice What did I do wrong in the tests for the effect? The selectors ignore my mocking implementation. |
...on/app/codeCharta/state/effects/updateVisibleTopLabels/updateVisibleTopLabels.effect.spec.ts
Outdated
Show resolved
Hide resolved
...ization/app/codeCharta/state/effects/updateVisibleTopLabels/updateVisibleTopLabels.effect.ts
Outdated
Show resolved
Hide resolved
...on/app/codeCharta/state/effects/updateVisibleTopLabels/updateVisibleTopLabels.effect.spec.ts
Outdated
Show resolved
Hide resolved
…er-of-displayed-labels' into feature/2584/adjust-default-number-of-displayed-labels
...on/app/codeCharta/state/effects/updateVisibleTopLabels/updateVisibleTopLabels.effect.spec.ts
Show resolved
Hide resolved
…er-of-displayed-labels' into feature/2584/adjust-default-number-of-displayed-labels
|
I would like to wait until Friday because I have a conversation with Torsten and there are still some questions open. |
…efault-number-of-displayed-labels
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
|
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
Hall-Ma
deleted the
feature/2584/adjust-default-number-of-displayed-labels
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust default number of displayed labels
Closes: #2584
Description