Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/2507/Link Height And Color Metric As New Default #3058

Merged
merged 49 commits into from Oct 11, 2022
Merged

Feature/2507/Link Height And Color Metric As New Default #3058

merged 49 commits into from Oct 11, 2022

Conversation

Hall-Ma
Copy link
Contributor

@Hall-Ma Hall-Ma commented Sep 28, 2022 •
edited

Link Height And Color Metric As New Default

Closes: #2507

Description

  • adds a new button that allows to couple height and color metric.
  • when this option is enabled then you can only change the height metric and the color metric changes automatically to the value of the height metric

Screenshots or gifs

By default this feature is not enabled:

image

This is what it looks like when height and color metrics are linked:

image

@Hall-Ma Hall-Ma marked this pull request as ready for review September 28, 2022 10:42
@Hall-Ma Hall-Ma changed the title Feature/2507/Couple Height And Color Metric As New Default Feature/2507/Link Height And Color Metric As New Default Sep 28, 2022
ce-bo
ce-bo reviewed Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the icon you have chosen for this! I will Test the new feature tomorrow. :-)

@ce-bo
Copy link
Collaborator

ce-bo commented Sep 29, 2022 •
edited

Here are some remarks:

  • If I link the metrics, then (on hovering the link button) the title should show "unlink metrics" instead of "link metrics".
  • I would like to add a title attribute for the color metric chooser, so that the user is going to be informed (on hover) that he/she should rather select the height metric instead because it is coupled/linked to that.
  • The UI looks a bit random, especially if the edge metrics are shown. So maybe we can improve it to make it more intuitive. Do you have a suggestion for that?
    image.

@ce-bo
Copy link
Collaborator

ce-bo commented Sep 29, 2022

I tryed something. Maybe this is one direction to express that height and color metric might be coupled together. But I am not happy with brush icon next to the chain icon:
image

@ce-bo
Copy link
Collaborator

ce-bo commented Sep 29, 2022

Another iteration: Please notice that the border is also underneath the height/color icon.
image

@Hall-Ma
Copy link
Contributor Author

Hall-Ma commented Oct 4, 2022

Thank you so much for your feedback!

@ce-bo
Copy link
Collaborator

ce-bo commented Oct 5, 2022

I really like the idea of @shaman-apprentice to disable the brush icon, when the metrics are linked. Let's do that :-)

Hall-Ma and others added 9 commits October 6, 2022 13:33
@Hall-Ma
Remove await from expect when using toMatch because IDE suggests it w…
646854a 
…rong

#2507
@Hall-Ma
Fix test for testing bursh icon color
c9ff819 
#3074
@Hall-Ma
Merge branch 'main' into feature/2507/couple-height-and-color-metric-…
7c71f4c 
…as-new-standard
@Hall-Ma
Finalize renaming of metric link action, add new action to set 'isCol…
1e5a231 
…orMetricLinkedToHeightMetric' property correctly when loading a custom config

#2057
@Hall-Ma
Finalize renaming of metric link action, add new action to set 'isCol…
ff74e3f 
…orMetricLinkedToHeightMetric' property correctly when loading a custom config

#2057
@Hall-Ma
Merge branch 'feature/2507/couple-height-and-color-metric-as-new-stan…
bc8d22f 
…dard' of github.com:MaibornWolff/codecharta into feature/2507/couple-height-and-color-metric-as-new-standard
@Hall-Ma
Merge branch 'main' into feature/2507/couple-height-and-color-metric-…
2db231e 
…as-new-standard
@Hall-Ma
Last renaming of observables and remove unused observable
6544a98 
#2057
@Hall-Ma
Add test for new action
292ec56 
#2057
@Hall-Ma Hall-Ma requested a review from ce-bo October 7, 2022 15:05
@jannikr jannikr self-requested a review October 11, 2022 07:30
jannikr
jannikr approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@jannikr jannikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Hall-Ma Hall-Ma enabled auto-merge (squash) October 11, 2022 09:02
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.4% 98.4% Coverage
0.0% 0.0% Duplication

@Hall-Ma Hall-Ma merged commit 99100c0 into main Oct 11, 2022
@Hall-Ma Hall-Ma deleted the feature/2507/couple-height-and-color-metric-as-new-standard branch October 11, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaman-apprentice shaman-apprentice shaman-apprentice left review comments

@BridgeAR BridgeAR BridgeAR left review comments

@jannikr jannikr jannikr approved these changes

@ce-bo ce-bo Awaiting requested review from ce-bo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "code quality default metric behavior"
5 participants
@Hall-Ma @ce-bo @shaman-apprentice @BridgeAR @jannikr