Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rerender when marking a folder with a color #3067

Merged
merged 3 commits into from
Oct 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/)

### Fixed 🐞

- Rerender immediately after marking a folder with a color [#3067](https://github.com/MaibornWolff/codecharta/pull/3067)
- Clicking the 'reset height metric settings' button resets the number of top labels to the dynamic default
value [#3066](https://github.com/MaibornWolff/codecharta/pull/3066)

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { MarkedPackagesActions } from "../../store/fileSettings/markedPackages/markedPackages.actions"
import { actionsRequiringRerender } from "./actionsRequiringRerender"

describe("actionsRequiringRerender", () => {
it("should include marked packages actions", () => {
expect(actionsRequiringRerender).toContain(MarkedPackagesActions)
})
})
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import { FocusedNodePathActions } from "../../store/dynamicSettings/focusedNodeP
import { HeightMetricActions } from "../../store/dynamicSettings/heightMetric/heightMetric.actions"
import { MarginActions } from "../../store/dynamicSettings/margin/margin.actions"
import { SearchPatternActions } from "../../store/dynamicSettings/searchPattern/searchPattern.actions"
import { MarkedPackagesActions } from "../../store/fileSettings/markedPackages/markedPackages.actions"

export const actionsRequiringRerender = [
ColorLabelsActions,
Expand All @@ -49,5 +50,6 @@ export const actionsRequiringRerender = [
HeightMetricActions,
AreaMetricActions,
ColorMetricActions,
ShowOnlyBuildingsWithEdgesActions
ShowOnlyBuildingsWithEdgesActions,
MarkedPackagesActions
]