Fix GitLogParser dialogues and docs #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In such cases, I would not reopen the issue. I would rather open a new bug issue. |
|
Is it still a draft PR? |
ce-bo
reviewed
Oct 7, 2022
ce-bo
approved these changes
Oct 7, 2022
|
LGTM. Thanks for the improvements! |
It was, since I was waiting for your feedback, but now I'm done. Thanks for the review! |
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! |
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GitLogParser dialogues and docs
Closes: #3078
Description
Some uncaught regressions were introduced in the new subcommands of the GitLogParser and #3041 , which are now fixed and covered by tests. There are also updates to the documentation to make clearer what the subcommands do internally. Formatting is also enhanced.