Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2489/subtitle for custom view modal #3085

Merged
merged 13 commits into from Oct 12, 2022

Conversation

jannikr
Copy link
Contributor

@jannikr jannikr commented Oct 11, 2022

Description to Custom Views modal

Issue: #2489

Description

Before:
Screenshot 2022-10-11 at 11 37 28

Now:
Screenshot 2022-10-11 at 11 35 04

@jannikr
Copy link
Contributor Author

jannikr commented Oct 11, 2022

@ce-bo We could think about removing the additional button for adding custom configs on the main page, because we already have the option in the current window (see screenshot). This would lead to more space in the toolbar and avoid redundant description texts.

@ce-bo
Copy link
Collaborator

ce-bo commented Oct 11, 2022

could think about r

I would like to keep it, as it is much easier to add multiple custom configs with the "shortcut-button".

jannikr and others added 4 commits October 12, 2022 09:14
…/customConfigList.component.html

Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
…/customConfigList.component.scss

Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
@jannikr jannikr marked this pull request as ready for review October 12, 2022 09:01
Copy link
Contributor

@Hall-Ma Hall-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jannikr and others added 4 commits October 12, 2022 11:14
…/customConfigList.component.scss

Co-authored-by: Maria Hallmann <72517530+Hall-Ma@users.noreply.github.com>
…-view-modal' into feature/2489/subtitle-for-custom-view-modal
@jannikr jannikr enabled auto-merge (squash) October 12, 2022 09:23
title: "Custom View"
---

Custom Views allow you to save and upload your individual configurations for certain maps. To save new configurations there is a "shortcut-button". In order to be able to access more settings, there is another button next to the "shortcut-button" with the following functions:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user could ask "Where can I find the shortcut-button?".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest adapting the user control documentation soon and then referring to it. That would have taken too much time now. I would be happy to open an issue for this @ce-bo ?

Copy link
Collaborator

@ce-bo ce-bo Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you! Would you be so kind to open the new issue for that?

Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: I added some remarks though to clearify some points.

jannikr and others added 3 commits October 12, 2022 11:47
…-view-modal' into feature/2489/subtitle-for-custom-view-modal
Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
@jannikr jannikr mentioned this pull request Oct 12, 2022
2 tasks
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jannikr jannikr merged commit 29f5eb8 into main Oct 12, 2022
@jannikr jannikr deleted the feature/2489/subtitle-for-custom-view-modal branch October 12, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants