New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2489/subtitle for custom view modal #3085
Conversation
@ce-bo We could think about removing the additional button for adding custom configs on the main page, because we already have the option in the current window (see screenshot). This would lead to more space in the toolbar and avoid redundant description texts. |
I would like to keep it, as it is much easier to add multiple custom configs with the "shortcut-button". |
visualization/app/codeCharta/ui/customConfigs/customConfigList/customConfigList.component.html
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/customConfigs/customConfigList/customConfigList.component.scss
Outdated
Show resolved
Hide resolved
…/customConfigList.component.html Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
…/customConfigList.component.scss Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
visualization/app/codeCharta/ui/customConfigs/customConfigList/customConfigList.component.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…/customConfigList.component.scss Co-authored-by: Maria Hallmann <72517530+Hall-Ma@users.noreply.github.com>
…-view-modal' into feature/2489/subtitle-for-custom-view-modal
title: "Custom View" | ||
--- | ||
|
||
Custom Views allow you to save and upload your individual configurations for certain maps. To save new configurations there is a "shortcut-button". In order to be able to access more settings, there is another button next to the "shortcut-button" with the following functions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user could ask "Where can I find the shortcut-button?".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest adapting the user control documentation soon and then referring to it. That would have taken too much time now. I would be happy to open an issue for this @ce-bo ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you! Would you be so kind to open the new issue for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: I added some remarks though to clearify some points.
…-view-modal' into feature/2489/subtitle-for-custom-view-modal
Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! |
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description to Custom Views modal
Issue: #2489
Description
Before:
Now: