Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/2489/implement partially applicable entries in custom configs #3090

Merged
merged 12 commits into from Oct 21, 2022
Merged

Feature/2489/implement partially applicable entries in custom configs #3090

merged 12 commits into from Oct 21, 2022

Conversation

Hall-Ma
Copy link
Contributor

@Hall-Ma Hall-Ma commented Oct 12, 2022 •
edited

Implement partially applicable entries in custom configs

Issue: #2489

Description

  • custom configs are now applicable even if selected maps or map selection mode differs
  • partially applicable custom configs are greyed out but still clickable
  • a tooltip shows what is still missing to complete the view (when something is missing)

@Hall-Ma Hall-Ma mentioned this pull request Oct 13, 2022
Closed
19 tasks
ce-bo
ce-bo reviewed Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so for :-)
I tested it lokally and the behavior looks fine!

@Hall-Ma
Add tests for customConfig2ApplicableColor and customConfig2Applicabl…
83907f5 
…eMessage

#2489
@Hall-Ma
Merge branch 'feature/2489/implement-partially-applicable-entries-in-…
00ea7a5 
…custom-configs' of github.com:MaibornWolff/codecharta into feature/2489/implement-partially-applicable-entries-in-custom-configs
@Hall-Ma
Add tests for getMissingCustomConfigModeAndMaps function
522492a 
#2489
@Hall-Ma
Add changelog entry
5686e60 
#2489
@Hall-Ma
Merge branch 'main' of github.com:MaibornWolff/codecharta into featur…
cd3bc3e 
…e/2489/implement-partially-applicable-entries-in-custom-configs
@Hall-Ma Hall-Ma marked this pull request as ready for review October 20, 2022 13:10
@jannikr jannikr self-requested a review October 21, 2022 09:05
jannikr
jannikr approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@jannikr jannikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Hall-Ma
Merge branch 'main' of github.com:MaibornWolff/codecharta into featur…
ab4b9c5 
…e/2489/implement-partially-applicable-entries-in-custom-configs
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Hall-Ma Hall-Ma merged commit de8be9b into main Oct 21, 2022
@Hall-Ma Hall-Ma deleted the feature/2489/implement-partially-applicable-entries-in-custom-configs branch October 21, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ce-bo ce-bo ce-bo left review comments

@jannikr jannikr jannikr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Hall-Ma @ce-bo @jannikr