Implementation of attributeDescriptors, a new json field that describes used metrics #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce-bo
reviewed
Oct 25, 2022
analysis/model/src/main/kotlin/de/maibornwolff/codecharta/model/AttributeDescriptor.kt
Outdated
Show resolved
Hide resolved
…o files are left behind
ce-bo
reviewed
Nov 21, 2022
ce-bo
approved these changes
Nov 21, 2022
|
As the next step I would prioritize to display the new descriptors in the Frontend. |
ce-bo
reviewed
Nov 21, 2022
...EdgeFilter/src/test/kotlin/de/maibornwolff/codecharta/filter/edgefilter/ProjectMergerTest.kt
Show resolved
Hide resolved
ce-bo
reviewed
Nov 22, 2022
...ifier/src/test/kotlin/de/maibornwolff/codecharta/filter/structuremodifier/NodeRemoverTest.kt
Outdated
Show resolved
Hide resolved
ce-bo
reviewed
Nov 22, 2022
...c/test/kotlin/de/maibornwolff/codecharta/filter/structuremodifier/SubProjectExtractorTest.kt
Outdated
Show resolved
Hide resolved
ce-bo
reviewed
Nov 22, 2022
...mport/CSVImporter/src/test/kotlin/de/maibornwolff/codecharta/importer/csv/CSVImporterTest.kt
Outdated
Show resolved
Hide resolved
ce-bo
reviewed
Nov 22, 2022
...CSVImporter/src/test/kotlin/de/maibornwolff/codecharta/importer/csv/CSVProjectBuilderTest.kt
Outdated
Show resolved
Hide resolved
ce-bo
reviewed
Nov 22, 2022
...gParser/src/test/kotlin/de/maibornwolff/codecharta/importer/gitlogparser/GitLogParserTest.kt
Show resolved
Hide resolved
ce-bo
approved these changes
Nov 22, 2022
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! |
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!
|
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attributeDescriptors basic implementation #1066
Issue: #1066
Description
This adds a new field to the produced json files from cc-analysis. This field functions as a map to describe the various attributes produced from the different importers/parsers. Those attribute/metric explanations can then be displayed in the cc-visualization to give the user additional information.
Screenshots or gifs
This is still a draft and only includes the outlines of the implementation, some features are not done or incomplete.
If there are any recommendations for changes, let me know 👍