fix: trigger auto fit only once after file selection

CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/)
 ### Fixed 🐞
 
 -   Fix broken link to Custom View documentation [#3101](https://github.com/MaibornWolff/codecharta/pull/3101)
+-   Don't re-center map after every state change like changing area metric [#3109](https://github.com/MaibornWolff/codecharta/pull/3109)
 
 ### Chore 👨‍💻 👩‍💻
 

visualization/app/codeCharta/state/effects/autoFitCodeMapChange/autoFitCodeMap.effect.spec.ts

@@ -84,6 +84,17 @@ describe("autoFitCodeMapOnFileSelectionChangeEffect", () => {
 		expect(mockedAutoFitTo).toHaveBeenCalledTimes(1)
 	})
 
+	it("should switch and not concat inner observable, so auto fit map gets called only once", () => {
+		mockedResetCameraIfNewFileIsLoadedSelector.mockImplementation(() => true)
+		mockedVisibleFileStates$.next("")
+		mockedFocusedNodePath$.next("")
+		mockedRenderCodeMap$.next("")
+		expect(mockedAutoFitTo).toHaveBeenCalledTimes(1)
+
+		mockedRenderCodeMap$.next("")
+		expect(mockedAutoFitTo).toHaveBeenCalledTimes(1)
+	})
+
 	it("should do nothing when 'reset camera if new file is loaded' is deactivated", () => {
 		mockedResetCameraIfNewFileIsLoadedSelector.mockImplementation(() => false)
 		mockedVisibleFileStates$.next("")

visualization/app/codeCharta/state/effects/autoFitCodeMapChange/autoFitCodeMap.effect.ts

@@ -1,5 +1,5 @@
 import { Inject, Injectable } from "@angular/core"
-import { concatMap, filter, skip, take, tap, combineLatest } from "rxjs"
+import { switchMap, filter, skip, take, tap, combineLatest } from "rxjs"
 import { ThreeOrbitControlsService } from "../../../ui/codeMap/threeViewer/threeOrbitControls.service"
 import { createEffect } from "../../angular-redux/effects/createEffect"
 import { State } from "../../angular-redux/state"
@@ -28,7 +28,7 @@ export class AutoFitCodeMapEffect {
 			]).pipe(
 				skip(1), // initial map load is already fitted
 				filter(() => resetCameraIfNewFileIsLoadedSelector(this.state.getValue())),
-				concatMap(() => this.renderCodeMapEffect.renderCodeMap$.pipe(take(1))),
+				switchMap(() => this.renderCodeMapEffect.renderCodeMap$.pipe(take(1))),
 				tap(() => {
 					this.threeOrbitControlsService.autoFitTo()
 				})