Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Adjust regex pattern for changelog dialog #3129

Merged
merged 2 commits into from Nov 10, 2022
Merged

Fix/Adjust regex pattern for changelog dialog #3129

merged 2 commits into from Nov 10, 2022

Conversation

Hall-Ma
Copy link
Contributor

@Hall-Ma Hall-Ma commented Nov 10, 2022

Fix showing changelog entries when new version is available

Description

  • The previous regex pattern was not properly formulated, it also found version entries that did not initiate a new release update
  • now the version is found only if it is enclosed in square brackets, e.g. [1.110.0]

@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@BridgeAR BridgeAR merged commit 517ec50 into main Nov 10, 2022
@BridgeAR BridgeAR deleted the fix/adjust-regex-pattern-for-changelog-dialog branch November 10, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hall-Ma @BridgeAR