Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/3095/ribbon-bar-bottom-line-isnt-fixed #3095 #3138

Merged
merged 8 commits into from Nov 23, 2022

Conversation

BenediktMehl
Copy link
Contributor

@BenediktMehl BenediktMehl commented Nov 18, 2022

Shadow of the ribbon bar now sticks to the elements even if the search is expanded

Close: #3095

Description

The shadow of the ribbon bar was moving down, when the search element was expanded.
This PR attaches the shadow to the elements itself in the ribbon bar by moving the box-shadow argument to the mat-card class.

Screenshots or gifs

Screenshot 2022-11-18 at 16 05 19

@BenediktMehl BenediktMehl linked an issue Nov 18, 2022 that may be closed by this pull request
@BenediktMehl BenediktMehl marked this pull request as ready for review November 18, 2022 15:08
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
@ce-bo
Copy link
Collaborator

ce-bo commented Nov 18, 2022

Small hint: You can change the description of this PR like the following to ensure that the issue will automatically be closed after merging the PR:
Old: "... Issue: #3095"
New: "... Close: #3095"

Copy link
Contributor

@MW-Friedrich MW-Friedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BenediktMehl BenediktMehl merged commit 1bd9827 into main Nov 23, 2022
@BenediktMehl BenediktMehl deleted the fix/3095/ribbon-bar-bottom-line-isnt-fixed branch November 23, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ribbon bar bottom line isn't fixed
3 participants