New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/3095/ribbon-bar-bottom-line-isnt-fixed #3095 #3138
Merged
BenediktMehl
merged 8 commits into
main
from
fix/3095/ribbon-bar-bottom-line-isnt-fixed
Nov 23, 2022
Merged
fix/3095/ribbon-bar-bottom-line-isnt-fixed #3095 #3138
BenediktMehl
merged 8 commits into
main
from
fix/3095/ribbon-bar-bottom-line-isnt-fixed
Nov 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce-bo
reviewed
Nov 18, 2022
Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
ce-bo
reviewed
Nov 18, 2022
visualization/app/codeCharta/ui/ribbonBar/ribbonBar.component.scss
Outdated
Show resolved
Hide resolved
ce-bo
reviewed
Nov 18, 2022
…lor metric chooser #3095 Add new mat-card that contains height-metric-chooser, link-metric-button and color-metric-chooser
MW-Friedrich
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! |
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shadow of the ribbon bar now sticks to the elements even if the search is expanded
Close: #3095
Description
The shadow of the ribbon bar was moving down, when the search element was expanded.
This PR attaches the shadow to the elements itself in the ribbon bar by moving the box-shadow argument to the mat-card class.
Screenshots or gifs