Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/3193/custom config todo due #3196

Merged
merged 8 commits into from
Jan 13, 2023
Merged

Fix/3193/custom config todo due #3196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
65209e6
fix: unit tests not working #3193
MW-Friedrich Jan 12, 2023
cfaf05b
chore: remove legacy camera transformation, closes #3139
MW-Friedrich Jan 12, 2023
60f9ba8
chore: remove legacy camera transformation, closes #3193
MW-Friedrich Jan 12, 2023
46aa584
Merge remote-tracking branch 'origin/fix/3139/customConfig-todo-due' …
MW-Friedrich Jan 12, 2023
6da61be
chore: bump customView api version #3193
MW-Friedrich Jan 13, 2023
fc29ca2
remove: checkForLegacyCameraSettingsOfCustomConfig #3193
MW-Friedrich Jan 13, 2023
5438bea
docs: update changelog #3193
MW-Friedrich Jan 13, 2023
ba61060
revert: un-bump custom config api version #3193
MW-Friedrich Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,18 @@ and this project adheres to [Semantic Versioning](http://semver.org/)

- Add an option to hide floor labels under the Area Metric Options. This recalculates the map. [#3175](https://github.com/MaibornWolff/codecharta/pull/3175)

### Chore 👨‍💻 👩‍💻
### Removed 🗑

- Add attribute descriptors (metric descriptions) to TokeiImporter and SVNlogParser [#3176](https://github.com/MaibornWolff/codecharta/pull/3176)
- Camera settings for custom views generated with version 1.101.1 and earlier are now ignored. [#3196](https://github.com/MaibornWolff/codecharta/pull/3196)

### Fixed 🐞

- Reposition legend panel button again, when attribute sidebar is open [#3183](https://github.com/MaibornWolff/codecharta/pull/3183)

### Chore 👨‍💻 👩‍💻

- Add attribute descriptors (metric descriptions) to TokeiImporter and SVNlogParser [#3176](https://github.com/MaibornWolff/codecharta/pull/3176)

## [1.113.0] - 2022-12-15

### Changed
Expand Down
14 changes: 0 additions & 14 deletions visualization/app/codeCharta/util/customConfigHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ export class CustomConfigHelper {
threeOrbitControlsService: ThreeOrbitControlsService
) {
const customConfig = this.getCustomConfigSettings(configId)
CustomConfigHelper.transformLegacyCameraSettingsOfCustomConfig(customConfig)
CustomConfigHelper.deleteUnusedKeyPropsOfCustomConfig(customConfig)

store.dispatch(setState(customConfig.stateSettings))
Expand All @@ -230,19 +229,6 @@ export class CustomConfigHelper {
}
}

// TODO [2023-01-01] remove support
private static transformLegacyCameraSettingsOfCustomConfig(customConfig: any) {
const appSettings = customConfig.stateSettings.appSettings
if (appSettings.camera || appSettings.cameraTarget) {
customConfig.camera = {
camera: appSettings.camera,
cameraTarget: appSettings.cameraTarget
}
delete customConfig.stateSettings.appSettings.camera
delete customConfig.stateSettings.appSettings.cameraTarget
}
}

// TODO [2023-04-01] remove support
private static deleteUnusedKeyPropsOfCustomConfig(customConfig: any) {
if (customConfig.stateSettings.treeMap || customConfig.stateSettings.fileSettings.attributeTypes) {
Expand Down