Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/3213/add notes to a custom view #3234

Merged
merged 23 commits into from Mar 24, 2023
Merged

Feature/3213/add notes to a custom view #3234

merged 23 commits into from Mar 24, 2023

Conversation

RomanenkoVladimir
Copy link
Member

@RomanenkoVladimir RomanenkoVladimir commented Feb 22, 2023 •
edited by Hall-Ma

Add notes to a custom view

closes: #3213

Description

Allows a user to add a note upon creating a new custom view, as well as Edit an existing custom view note from the "custom-view-menu".

Screenshots or gifs

Input field on custom view creation:

Preview and edit button on "custom-view-menu":

Edit Note Dialog:

@RomanenkoVladimir RomanenkoVladimir linked an issue Feb 22, 2023 that may be closed by this pull request
Add notes to a Custom View #3213
Closed
ce-bo
ce-bo reviewed Mar 1, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
ce-bo
ce-bo reviewed Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Custom View Items are a bit shifted in the UI. Whould you please have a look?
I think the Icons for the metrics should be at the same x position. So I guess the area on the left including the name and note should have a kind of fixed size. And the pen/edit icon for the note should be next to the note text.
image

@ce-bo ce-bo mentioned this pull request Mar 10, 2023
Closed
Merge branch 'main' into feature/3213/add-notes-to-a-custom-view
4d41a05 
# Conflicts:
#	CHANGELOG.md
#	visualization/app/codeCharta/ui/customConfigs/customConfigList/customConfigItemGroup/customConfigDescription/applyCustomConfigButton.component.html
#	visualization/app/codeCharta/ui/customConfigs/customConfigList/customConfigItemGroup/customConfigDescription/applyCustomConfigButton.component.scss
@ce-bo ce-bo force-pushed the feature/3213/add-notes-to-a-custom-view branch from 8245459 to 4d41a05 Compare March 17, 2023 16:24
@ce-bo
Copy link
Collaborator

ce-bo commented Mar 17, 2023

I migrated the angular legacy dialogs. Now the custom views are visible again but the list items are looking broken.
image

It could be the case that I did a mistake when merging the main branch.
Maybe someone can check this and continue here?

@Hall-Ma
Copy link
Contributor

Hall-Ma commented Mar 20, 2023

I migrated the angular legacy dialogs. Now the custom views are visible again but the list items are looking broken. image

It could be the case that I did a mistake when merging the main branch. Maybe someone can check this and continue here?

I will take over the issue.

@Hall-Ma
Copy link
Contributor

Hall-Ma commented Mar 20, 2023 •
edited

I have updated the list of custom views. It is much nicer when the custom view titles and notes are one below the other. Also, the edit button of the notes shows a hover behavior.

@Hall-Ma Hall-Ma force-pushed the feature/3213/add-notes-to-a-custom-view branch from dee453c to 9e880cc Compare March 21, 2023 10:09
@Hall-Ma Hall-Ma requested a review from ce-bo March 22, 2023 16:00
phanlezz
phanlezz approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@phanlezz phanlezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean now!
If we merge #3239 we could merge the truncate pipe into the new simplePipes module.

@Hall-Ma Hall-Ma enabled auto-merge (squash) March 24, 2023 13:39
@Hall-Ma Hall-Ma disabled auto-merge March 24, 2023 13:41
@Hall-Ma Hall-Ma enabled auto-merge (squash) March 24, 2023 13:44
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.2% 93.2% Coverage
0.0% 0.0% Duplication

@Hall-Ma Hall-Ma merged commit 2cd4339 into main Mar 24, 2023
7 checks passed
@Hall-Ma Hall-Ma deleted the feature/3213/add-notes-to-a-custom-view branch March 24, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hall-Ma Hall-Ma Hall-Ma left review comments

@phanlezz phanlezz phanlezz approved these changes

@ce-bo ce-bo Awaiting requested review from ce-bo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add notes to a Custom View
4 participants
@RomanenkoVladimir @ce-bo @Hall-Ma @phanlezz