Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/improve custom views dialog styling #3248

Merged
merged 7 commits into from Mar 17, 2023

Conversation

IhsenBouallegue
Copy link
Collaborator

@IhsenBouallegue IhsenBouallegue commented Mar 14, 2023

Improve custom views dialog styling

ref #3225

Description

Descriptive pull request text, answering:

  • Fix custom views dialog styling and make it consistent with the others.

Note: I discovered that the expansion panel / accordion is not being styled correctly from material UI. I couldn't find the reason as everything is imported correctly.
It should look like this per default:
image

Screenshots or gifs

Before:
image
After:
image
image

@IhsenBouallegue
Copy link
Collaborator Author

I won't be available for the next 2 weeks, so if everything is green you can merge this! 😄

@ce-bo
Copy link
Collaborator

ce-bo commented Mar 15, 2023

For me it looks differently:
image

@shaman-apprentice shaman-apprentice self-assigned this Mar 16, 2023
@shaman-apprentice
Copy link
Contributor

For me it looks differently: image

For me it looks fine
image

When you reduce browser width so the dialog contents doesn't fit anymore into it, it looks like your pic. For me that is OK, what do you think? @ce-bo

@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@shaman-apprentice shaman-apprentice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

Thanks to all who participated!

@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Hall-Ma
Copy link
Contributor

Hall-Ma commented Mar 17, 2023

For me it looks differently: image

For me it looks fine image

When you reduce browser width so the dialog contents doesn't fit anymore into it, it looks like your pic. For me that is OK, what do you think? @ce-bo

I have fixed the problem. Before, it looked like Cedric's screenshot when you have the full width of the screen. Now it's more flexy, when you reduce the browser size :)

@shaman-apprentice shaman-apprentice merged commit e0e4288 into main Mar 17, 2023
7 checks passed
@shaman-apprentice shaman-apprentice deleted the fix/improve-customt-views-dialog-styling branch March 17, 2023 15:59
Hall-Ma added a commit that referenced this pull request Mar 23, 2023
* style: fix custom view dialog title

* style: fix expansion list item and buttons layout

* docs: add changelog entry

* Fix direction of custom config description and overlapping of remove button

* refactor: remove overwritten max-height

ref #3248

* refactor: make prettier happy

ref #3248

* Fix width of metric chooser selects and prevent hiding when browser is reduced, also adjust width of ai component
#3225

---------

Co-authored-by: IhsenBouallegue <bouallegueihsen@gmail.com>
Co-authored-by: shaman-apprentice <torsten.knauf@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants