Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/3225/ui components #3260

Merged
merged 9 commits into from Mar 30, 2023
Merged

Fix/3225/ui components #3260

merged 9 commits into from Mar 30, 2023

Conversation

Hall-Ma
Copy link
Contributor

@Hall-Ma Hall-Ma commented Mar 30, 2023 •
edited

Fix UI components

Issue: #3225

Screenshots or gifs

image
image
image
image
(double borderline removed on the right side of each mat-card)

@Hall-Ma Hall-Ma marked this pull request as ready for review March 30, 2023 11:33
phanlezz
phanlezz approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@phanlezz phanlezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Hall-Ma Hall-Ma enabled auto-merge (squash) March 30, 2023 14:27
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Hall-Ma Hall-Ma merged commit 598e2f4 into main Mar 30, 2023
7 checks passed
@Hall-Ma Hall-Ma deleted the fix/3225/ui-components branch March 30, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanlezz phanlezz phanlezz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hall-Ma @phanlezz