Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/3262/Missing suspicious metrics feature #3263

Merged
merged 4 commits into from Apr 3, 2023
Merged

Fix/3262/Missing suspicious metrics feature #3263

merged 4 commits into from Apr 3, 2023

Conversation

Hall-Ma
Copy link
Contributor

@Hall-Ma Hall-Ma commented Mar 31, 2023 •
edited

Fixing the disappearance of suspicious metric

Close: #3262

Description

  • fix unhandled return value of artificialIntelligenceSelector when no unifiedMaps are available (e.g. when loading the website for the first time)

ce-bo
ce-bo approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You might want to add a regression test for that?

@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Hall-Ma Hall-Ma merged commit b216dfb into main Apr 3, 2023
7 checks passed
@Hall-Ma Hall-Ma deleted the fix/3262/missing-suspicious-metrics-feature branch April 3, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ce-bo ce-bo ce-bo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Icons for Suspicious Metrics Feature in ribbon bar
2 participants
@Hall-Ma @ce-bo