Feature/3253/electron swap #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add hints to readme in visualization; Add zip step to github release action;
ce-bo
reviewed
Oct 11, 2023
ce-bo
reviewed
Oct 11, 2023
gh-pages/_posts/adr/2023-10-09-ADR_10_change_visualization_standalone.md
Show resolved
Hide resolved
ce-bo
reviewed
Oct 11, 2023
ce-bo
approved these changes
Oct 11, 2023
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
|
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap to a new runner for Visualization (From NW.JS to Electron)
Due to the issues with nw.js and its builder derivatives we want to swap to electron for the visualization.
This means, that we also swap to a new packager.
Additionally, electron provides an arm version which enables codecharta to run natively on new apple silicon.
Issue: #3253
Workflow
npm run startnpm run packageNotes
Standalone desktop app tested on Windows 10/11 and Ubuntu 22.04.