Fix/3321/fix stuck metric gardener importer #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce-bo
reviewed
Oct 30, 2023
| inputFile = tempMgOutput | ||
| if (processExitCode != 0) { | ||
| throw InternalException("Error while executing metric gardener! Process returned with status $processExitCode.") |
There was a problem hiding this comment.
I would prefer to create a custom exception class for MetricGardener errors.
Replaced shellRun function which caused this
Adjusted test to not fail on windows
Adjusted test to not fail on windows
Fixes build issues
Nereboss
force-pushed
the
fix/3321/fix-stuck-metric-gardener-importer
branch
from
726588b
to
41fe258
Compare
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! |
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix metric gardener importer getting stuck on larger folders
A known issue in the ShellRun function caused extensive runtimes for folders where the output of metric gardener was long. This was fixed by swapping out the ShellRun function for ProcessBuilder and discarding the output of metric gardener.
Issue: #3321
Notes
Tested on Mac in zsh shell