Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/3406/fix rawtextparser input handling 1 #3415

Merged
merged 4 commits into from Nov 24, 2023

Conversation

fritschldwg
Copy link
Collaborator

@fritschldwg fritschldwg commented Nov 21, 2023

Fix/3406/fix rawtextparser input handling 1

Issue: #3406

Description

  • When an empty string is provided as the value for the 'metrics,' 'file-extensions,' or 'exclude' flag, the rawtextparser now correctly handles these inputs by filtering out the empty strings.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualisation READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

@ce-bo
Copy link
Collaborator

ce-bo commented Nov 22, 2023

Would you please add the link to this PR on the related bullet point within the issue?

@phanlezz
Copy link
Collaborator

phanlezz commented Nov 22, 2023

I'm getting this error if I try to parse the codecharta directory:
grafik
Ignore the double line for regex (I was resizing the window)

Edit: There might be a mistake in my call, if so, ignore this :)

I tried to only parse.ktfiles, but got the same problem:
grafik

@Nereboss
Copy link
Collaborator

I'm getting this error if I try to parse the codecharta directory: grafik Ignore the double line for regex (I was resizing the window)

Edit: There might be a mistake in my call, if so, ignore this :)

I tried to only parse.ktfiles, but got the same problem: grafik

We are aware of this error, it is planned that it is not addressed in this PR as it is caused by the max-indentation-level flag will be fixed in a future PR of this bigger issue. If you paste the command the interactive mode gave you and remove the max-indentation-level flag then everything should work (at least it does in my machine)

Copy link

sonarcloud bot commented Nov 22, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link

sonarcloud bot commented Nov 22, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Nereboss Nereboss merged commit 1db8b42 into main Nov 24, 2023
7 checks passed
@Nereboss Nereboss deleted the fix/3406/fix-rawtextparser-input-handling-1 branch November 24, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants