Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file extension for merged project #3409 #3421

Merged
merged 5 commits into from Nov 28, 2023
Merged

Fix file extension for merged project #3409 #3421

merged 5 commits into from Nov 28, 2023

Conversation

fritschldwg
Copy link
Collaborator

@fritschldwg fritschldwg commented Nov 27, 2023 •
edited

Fix file extension for merged project #3409

Closes: #3409

Description

  • The problem with unsupported API versions occurs when selecting the analysis folder. This happens because there are test files in this folder with API versions lower than 1.0, used for testing invalid versions. When using the analysis folder as input for the merge filter, it correctly throws an error
  • Fix: The file extension of the merged project was set incorrectly and has now been corrected

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualisation READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

@fritschldwg fritschldwg reopened this Nov 27, 2023
@fritschldwg fritschldwg force-pushed the fix/3409/api-versions-not-supported branch from fd07a59 to ba48c4e Compare November 28, 2023 08:58
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Nereboss
Nereboss approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@Nereboss Nereboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nereboss Nereboss merged commit 6d37789 into main Nov 28, 2023
7 checks passed
@Nereboss Nereboss deleted the fix/3409/api-versions-not-supported branch November 28, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nereboss Nereboss Nereboss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MergeFilter - API versions not supported
2 participants
@fritschldwg @Nereboss